Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: message alignment #4503

Merged
merged 2 commits into from
Aug 10, 2021
Merged

fix: message alignment #4503

merged 2 commits into from
Aug 10, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Aug 7, 2021 •
edited
Loading

Details

This PR only touches base for inline code block and trimming behavior is being fixed in other PR. I have raised the issue with react-native-render-html and this issue is caused by the recent upgrade of this lib to v6 and As soon as the library fix this issue, I will send another PR to merge that fix.

Fixed Issues

$ Fixes #4488

Tests | QA Steps

  1. Send a multiple-line message and observe the behavior. all lines should be in their own line.
  2. Send two single-line messages and observe the behavior. They should lie in their own lines.
text - first line
text - second line

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web | Desktop

image

Mobile Web

Screenshot 2021-08-09 23:10:32

iOS

Android

Screenshot 2021-08-09 23:09:22

@parasharrajat parasharrajat requested a review from a team as a code owner August 7, 2021 19:14
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team August 7, 2021 19:14
HorusGoul
HorusGoul reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@HorusGoul HorusGoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of behavior should I expect after each text message from the test steps? I do not see anything noticeable.

@parasharrajat
Copy link
Member Author

Sorry, @HorusGoul Forgot to mention that I will upload the screens shortly.

@HorusGoul
Copy link
Contributor

Great, thanks!

@parasharrajat
Copy link
Member Author

@HorusGoul All set.

@parasharrajat parasharrajat mentioned this pull request Aug 9, 2021
Closed
@HorusGoul HorusGoul merged commit c9d2e75 into Expensify:main Aug 10, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor

Going to CP this to staging

@roryabraham
Copy link
Contributor

Ah GH Actions are currently down: https://www.githubstatus.com/

I think I'll have to try again later

@roryabraham
Copy link
Contributor

roryabraham commented Aug 11, 2021 •
edited
Loading

Okay, CPing this again now. Should be deployed in 1.0.83-1

github-actions bot pushed a commit that referenced this pull request Aug 11, 2021
@HorusGoul
Merge pull request #4503 from parasharrajat/fix-alignment
a7f5f9a 
fix: message alignment
(cherry picked from commit c9d2e75)
@OSBotify OSBotify mentioned this pull request Aug 11, 2021
Merged
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.83-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 11, 2021
Closed
53 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @francoisl in version: 1.0.83-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @HorusGoul in version: 1.0.83-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@arielgreen arielgreen mentioned this pull request Aug 13, 2021
Closed
@botify
Copy link

botify commented Aug 17, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-08-24. 🎊

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @isagoico in version: 1.0.85-9 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 17, 2021
Closed
This was referenced Aug 25, 2021
Closed
Closed
This was referenced Sep 2, 2021
Closed
Closed
@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorusGoul HorusGoul HorusGoul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web - Chronos - Reply text for the commands "top" and "top help" are misaligned
5 participants
@parasharrajat @HorusGoul @OSBotify @roryabraham @botify